Bump halo2curves to 0.7 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnevadoc
force-pushed
the
nev@bump-halo2curves
branch
from
4783184 to
1e771bc
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
=======================================
Coverage 82.64% 82.64%
=======================================
Files 84 84
Lines 17750 17750
=======================================
+ Hits 14669 14670 +1
+ Misses 3081 3080 -1 ☔ View full report in Codecov by Sentry. |
kilic
approved these changes
Sep 12, 2024
guorong009
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
LGTM! 🚀
I believe we should close following duplicate PR when merging this one.
#364
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.